fix: use block-style YAML sequences in SKILL.md frontmatter#560
fix: use block-style YAML sequences in SKILL.md frontmatter#560ademakdogan wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 923a1d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the YAML output for skill frontmatter to comply with stricter parsing rules, specifically those enforced by Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly replaces YAML flow sequences with block-style sequences in the generated SKILL.md frontmatter to ensure compatibility with strictyaml. The changes are applied consistently across service, shared, persona, and recipe skill templates. The addition of unit tests to verify the output format is a great improvement that will prevent regressions. I have one suggestion regarding the new test assertions to make them more robust against future changes.
Replace flow sequences (bins: ["gws"], skills: [...]) with block-style sequences in all generated SKILL.md frontmatter templates. Flow sequences are valid YAML but rejected by strictyaml, which the Agent Skills reference implementation (agentskills validate) uses to parse frontmatter. This caused all 93 generated skills to fail validation. Also adds unit tests verifying that service, shared, persona, and recipe skill templates produce block-style sequences only. Fixes googleworkspace#521
ademakdogan
force-pushed
the
fix/skill-frontmatter-block-sequences
branch
from
b4bf22c to
923a1d6
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly resolves the YAML validation issue by converting flow-style sequences to block-style sequences in the generated SKILL.md frontmatter. The changes are applied consistently across all relevant skill generation functions. The addition of a comprehensive set of unit tests is a significant improvement that ensures the generated YAML remains compliant and prevents future regressions. The code is clean, focused, and effectively addresses the problem.
2 participants
Description
Replace flow sequences (
bins: ["gws"],skills: [...]) with block-style sequences in all generated SKILL.md frontmatter templates.Flow sequences are valid YAML but rejected by
strictyaml, which the Agent Skills reference implementation (agentskills validate) uses to parse frontmatter. This caused all 93 generated skills to fail validation.Also adds unit tests verifying that service, shared, persona, and recipe skill templates produce block-style sequences only.
Fixes #521
Dry Run Output:
N/AChecklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.